I brown after all metal work is done. After the sights have been installed.
on a rifle, when you might want to tap the sight back and forth, brown without the sight in place. If you need to clean the dovetail to get the sight to fit again, it's OK, because the sight base is large enough to cover the entire dovetail.